TW-1570 Implement hiding 'All Networks' option #1220
Closed
+32
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshan3262
had a problem deploying
to
development
GitHub Actions
Error
keshan3262
had a problem deploying
to
development
GitHub Actions
Error
keshan3262
temporarily deployed
to
development
GitHub Actions
Inactive
lendihop
approved these changes
Nov 5, 2024
alex-tsx
reviewed
Nov 7, 2024
Comment on lines
+3
to
+15
| type SearchNetwork = string | { name: string }; | ||
|
|
||
| export const searchNetworksByName = <T extends SearchNetwork>(networks: T[], searchValue: string) => { | ||
| const preparedSearchValue = searchValue.trim().toLowerCase(); | ||
|
|
||
| return preparedSearchValue | ||
| ? searchAndFilterItems( | ||
| networks.filter(network => typeof network !== 'string'), | ||
| preparedSearchValue, | ||
| [{ name: 'name', weight: 1 }] | ||
| ) | ||
| : networks; | ||
| }; |
There was a problem hiding this comment.
No need to search by that 'all networks' string, as dictated by the task requirements.
+ I18N:
export function searchAndFilterChains(networks: OneOfChains[], searchValue: string) {
return searchAndFilterItems(
networks,
searchValue.trim(),
[
{ name: 'name', weight: 1 },
{ name: 'nameI18n', weight: 1 }
],
({ name, nameI18nKey }) => ({
name,
nameI18n: nameI18nKey ? t(nameI18nKey) : undefined
})
);
}See implementation here: https://github.com/madfish-solutions/templewallet-extension/blob/TW-1479-evm-transactions-history/src/lib/ui/search-networks.ts
IrynaKhyzhynska
had a problem deploying
to
development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.